Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for excludeFields property does not work for update operations #104

Merged
merged 3 commits into from
Jul 29, 2013
Merged

Conversation

ozanozen
Copy link
Contributor

fix for #103

@buildhive
Copy link

Richard Louapre » elasticsearch-river-mongodb #45 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@ozanozen
Copy link
Contributor Author

I Richard I wasn't able to pinpoint the problem. It looks like a straightforward merge. O tried to fix it locally but there doesn't seem to be a change in the master branch. Can you comment on the problem?

@richardwilly98
Copy link
Owner

@ozanozen that's usually a timing issue (in the unit test) between the time documents get indexed in MongoDB and the time they get stored in ES. So the build is unfortunately not successful every time.

I will try to merge and confirm if that's the issue.

@richardwilly98
Copy link
Owner

@ozanozen actually the issue was only because you did not use the latest version of the source code and the automatic merge did not work.
I have merged your changes manually they will be available in HEAD soon.
I have also updated the unit test to validate your changes.

Thanks for the contribution.

richardwilly98 added a commit that referenced this pull request Jul 29, 2013
- Also included updated unit test in RiverMongoExcludeFieldsTest
@richardwilly98 richardwilly98 merged commit 6f57fc1 into richardwilly98:master Jul 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants