Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to select error measure #32

Closed
richelbilderbeek opened this issue Jan 21, 2019 · 0 comments
Closed

Allow to select error measure #32

richelbilderbeek opened this issue Jan 21, 2019 · 0 comments
Assignees
@richelbilderbeek
Labels
medium priority Do this after the high priority Issues
Projects
v1.2

Comments

@richelbilderbeek
Copy link
Owner

richelbilderbeek commented Jan 21, 2019 •
edited
Loading

Currently, the nLTT statistic is used as an error measure. It would be better to let the user specify which error measure he/she wants.

This need not be hard (code only a guideline):

pir_run(
  error = function(phylogeny, phylogenies) { nLTT.nltt_diffs(phylogeny, phylogenies) },
  ...
)
@richelbilderbeek richelbilderbeek added this to To do in v1.2 via automation Jan 21, 2019
@richelbilderbeek richelbilderbeek mentioned this issue Jan 21, 2019
Closed
richelbilderbeek pushed a commit that referenced this issue Jan 23, 2019
Adding 'error_measure_params', progress #29, #32 and #34
c2ff28a
@richelbilderbeek richelbilderbeek moved this from To do to In progress in v1.2 Jan 23, 2019
@richelbilderbeek richelbilderbeek self-assigned this Jan 23, 2019
@richelbilderbeek richelbilderbeek added the medium priority Do this after the high priority Issues label Jan 23, 2019
@richelbilderbeek richelbilderbeek moved this from In progress to Maybe done in v1.2 Jan 23, 2019
v1.2 automation moved this from Maybe done to Done Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richelbilderbeek richelbilderbeek

Labels
medium priority Do this after the high priority Issues
Projects
v1.2
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richelbilderbeek