Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify where the BEAST2 output files are stored #64

Closed
1 task done
richelbilderbeek opened this issue Jan 28, 2019 · 2 comments
Closed
1 task done

Specify where the BEAST2 output files are stored #64

richelbilderbeek opened this issue Jan 28, 2019 · 2 comments
Assignees
Labels
depends Must solve other Issue before doing this one medium priority Do this after the high priority Issues
Projects

Comments

@richelbilderbeek
Copy link
Owner

richelbilderbeek commented Jan 28, 2019

Depends on:

It should be possible to specify to pirouette where the BEAST2 output files are stored. This is essantial for both raket and razzo.

Currently, due to the model selection, this feature is lost.

And additionally, I never liked those model selection functions.

I think it's best to ditch the model_select_params in favour of a list of inference models. Each inference model must have:

  • a type: generative or candidate
  • a site model, clock model, tree prior
  • an optional MRCA prior
  • the BEAST2 input and output filenames
@richelbilderbeek richelbilderbeek added this to To do in v1.2 via automation Jan 28, 2019
@richelbilderbeek richelbilderbeek self-assigned this Jan 28, 2019
@richelbilderbeek richelbilderbeek added the high priority Do this first label Jan 28, 2019
@richelbilderbeek richelbilderbeek moved this from To do to In progress in v1.2 Jan 28, 2019
@richelbilderbeek richelbilderbeek moved this from In progress to To do in v1.2 Jan 29, 2019
@richelbilderbeek
Copy link
Owner Author

Depends on #69

@richelbilderbeek richelbilderbeek added depends Must solve other Issue before doing this one medium priority Do this after the high priority Issues and removed high priority Do this first labels Jan 30, 2019
@richelbilderbeek
Copy link
Owner Author

Done! It is part of create_experiment()$beast2_options

v1.2 automation moved this from To do to Done Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends Must solve other Issue before doing this one medium priority Do this after the high priority Issues
Projects
v1.2
  
Done
Development

No branches or pull requests

1 participant