Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge model_select_params and inference_params into a list of experiments #69

Closed
6 tasks done
richelbilderbeek opened this issue Jan 30, 2019 · 4 comments
Closed
6 tasks done
Assignees
Labels
high priority Do this first
Projects

Comments

@richelbilderbeek
Copy link
Owner

richelbilderbeek commented Jan 30, 2019

@richelbilderbeek richelbilderbeek added the high priority Do this first label Jan 30, 2019
@richelbilderbeek richelbilderbeek self-assigned this Jan 30, 2019
@richelbilderbeek richelbilderbeek added this to To do in v1.2 via automation Jan 30, 2019
@richelbilderbeek richelbilderbeek moved this from To do to In progress in v1.2 Jan 30, 2019
@richelbilderbeek richelbilderbeek added the depends Must solve other Issue before doing this one label Jan 30, 2019
@richelbilderbeek richelbilderbeek changed the title Merge model_select_params and inference_params into something easier Merge model_select_params and inference_params into a list of experiments Jan 31, 2019
@richelbilderbeek
Copy link
Owner Author

richelbilderbeek commented Jan 31, 2019

Yes, this is the superior way to go: better words, re-use structures from beautier and beastier.

Only the word experiment can be improved... 🤔

But well, it's good, good enough for now 🏎️ 🏎️

@richelbilderbeek
Copy link
Owner Author

Old:

pir_run(
  phylogeny = ...,
  twinning_params = ...,
  alignment_params = ...,
  model_select_params = ...,
  inference_params = ...,
  error_measure_params = ...
)

New:

pir_run(
  phylogeny = ...,
  twinning_params = ...,
  alignment_params = ...,
  experiments = ...,
  error_measure_params = ...
)

@richelbilderbeek
Copy link
Owner Author

richelbilderbeek pushed a commit that referenced this issue Jan 31, 2019
@richelbilderbeek richelbilderbeek removed the depends Must solve other Issue before doing this one label Jan 31, 2019
@richelbilderbeek richelbilderbeek added the depends Must solve other Issue before doing this one label Jan 31, 2019
@richelbilderbeek richelbilderbeek added depends Must solve other Issue before doing this one and removed depends Must solve other Issue before doing this one labels Feb 4, 2019
@richelbilderbeek richelbilderbeek added depends Must solve other Issue before doing this one and removed depends Must solve other Issue before doing this one labels Feb 5, 2019
richelbilderbeek pushed a commit that referenced this issue Feb 5, 2019
@richelbilderbeek
Copy link
Owner Author

Done!

Sure, there is more to be done, but there are tests confirming this Issue is mostly done.

v1.2 automation moved this from In progress to Done Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Do this first
Projects
v1.2
  
Done
Development

No branches or pull requests

1 participant