Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build under Windows #71

Closed
1 task done
richelbilderbeek opened this issue Jan 31, 2019 · 3 comments
Closed
1 task done

Build under Windows #71

richelbilderbeek opened this issue Jan 31, 2019 · 3 comments
Assignees
Labels
low priority Do this after the medium priority Issues
Projects

Comments

@richelbilderbeek
Copy link
Owner

richelbilderbeek commented Jan 31, 2019

Depends on:

I see there are some vignettes that ruthlessly ignore Windows users. No wonder AppVeyor's build does not work. It would be good if a Windows user would try to get 'Check Package' working. If that works, assign me/you to #70 to get it built under AppVeyor.

I think @Giappo would like to express his love for his OS by doing this Issue 🌈🌈🌈

@richelbilderbeek richelbilderbeek added depends Must solve other Issue before doing this one low priority Do this after the medium priority Issues labels Jan 31, 2019
@richelbilderbeek richelbilderbeek added this to To do in v1.2 via automation Jan 31, 2019
@richelbilderbeek richelbilderbeek removed the depends Must solve other Issue before doing this one label Feb 6, 2019
@richelbilderbeek
Copy link
Owner Author

Travis does not support Windows builds of R yet 😐

@Giappo
Copy link
Collaborator

Giappo commented Feb 18, 2019

"Check Package" actually works perfectly on windows.
Of course all the vignette parts where mcbette needs to be called are skipped, but it does pass the check.
If you think it's enough we can close the issue.

@Giappo Giappo moved this from To do to In progress in v1.2 Feb 18, 2019
@Giappo Giappo moved this from In progress to Maybe done in v1.2 Feb 18, 2019
@richelbilderbeek
Copy link
Owner Author

That's enough. Thanks for checking 👍

Closing the Issue 🌈

v1.2 automation moved this from Maybe done to Done Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Do this after the medium priority Issues
Projects
v1.2
  
Done
Development

No branches or pull requests

2 participants