RF-13220: Remove dual-branding and references to AS 7. Also clean up errors reported by QS tools #8
Conversation
It's fine for me! |
Thanks @sgilda, I'll review this shortly. |
Thanks @bleathem |
|
||
|
||
|
||
Configure Maven |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section on configuring maven and the associated profiles is unnecessary for the RichFaces quickstarts, as they are designed to be built from maven central.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added that section because each of the individual quickstart README files has a link to a Configure Maven in the parent README and there wasn't one. So the README files had broken links. See: https://github.com/richfaces/jdf-quickstarts/blob/master/helloworld-rf/README.md#configure-maven
Won't they need those instructions when the quickstart is merged in with the WFK quickstarts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instructions will be required for the WFK qucikstarts. Is the script that @rafabene runs able to add them?
@sgilda this looks great. Thanks for taking on this task, it's much appreciated. Other than my one inline comment above, this Pull request looks good to me. |
… errors reported by QS tools
@bleathem : I kept the link to the root README in the individual quickstart README files. In the root README of this project, it just states : "The quickstarts in the RichFaces project are designed to use artifacts in Maven Central. There is no need to configure Maven before you build and deploy the quickstarts." If they click the link in the RichFaces project, it tells them there is no need to configure Maven. Does this work for you? |
@sgilda that's a great solution, thanks! |
No description provided.