Skip to content
This repository has been archived by the owner on Nov 17, 2017. It is now read-only.

RF-13220: Remove dual-branding and references to AS 7. Also clean up errors reported by QS tools #8

Merged
merged 1 commit into from Jan 7, 2014

Conversation

sgilda
Copy link
Contributor

@sgilda sgilda commented Jan 6, 2014

No description provided.

@rafabene
Copy link
Contributor

rafabene commented Jan 6, 2014

It's fine for me!

@sgilda
Copy link
Contributor Author

sgilda commented Jan 6, 2014

Thanks @rafabene :-)

@bleathem : Please let me know if you need me to make any other changes.

@bleathem
Copy link
Member

bleathem commented Jan 6, 2014

Thanks @sgilda, I'll review this shortly.

@sgilda
Copy link
Contributor Author

sgilda commented Jan 6, 2014

Thanks @bleathem




Configure Maven
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section on configuring maven and the associated profiles is unnecessary for the RichFaces quickstarts, as they are designed to be built from maven central.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added that section because each of the individual quickstart README files has a link to a Configure Maven in the parent README and there wasn't one. So the README files had broken links. See: https://github.com/richfaces/jdf-quickstarts/blob/master/helloworld-rf/README.md#configure-maven

Won't they need those instructions when the quickstart is merged in with the WFK quickstarts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions will be required for the WFK qucikstarts. Is the script that @rafabene runs able to add them?

@bleathem
Copy link
Member

bleathem commented Jan 7, 2014

@sgilda this looks great. Thanks for taking on this task, it's much appreciated. Other than my one inline comment above, this Pull request looks good to me.

@sgilda
Copy link
Contributor Author

sgilda commented Jan 7, 2014

@bleathem : I kept the link to the root README in the individual quickstart README files. In the root README of this project, it just states : "The quickstarts in the RichFaces project are designed to use artifacts in Maven Central. There is no need to configure Maven before you build and deploy the quickstarts."

If they click the link in the RichFaces project, it tells them there is no need to configure Maven.
If they click the link in the WFK version, it gives them the complete Maven configuration instructions.

Does this work for you?

@bleathem
Copy link
Member

bleathem commented Jan 7, 2014

@sgilda that's a great solution, thanks!

@bleathem bleathem merged commit 92c2461 into richfaces:master Jan 7, 2014
@sgilda sgilda deleted the RF-13220 branch March 17, 2014 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants