Skip to content
This repository has been archived by the owner on Nov 17, 2017. It is now read-only.

Ftest #42

Closed
wants to merge 6 commits into from
Closed

Ftest #42

wants to merge 6 commits into from

Conversation

jstefek
Copy link
Contributor

@jstefek jstefek commented Sep 12, 2012

Created tests for pickList.

@buildhive
Copy link

RichFaces » sandbox #152 SUCCESS
This pull request looks good
(what's this?)

@lfryc
Copy link
Contributor

lfryc commented Oct 31, 2012

Jirka, I apologize I wasn't able to get to this PR before.

Could you please look into following modifications?

  • replace TestNG with JUnit
  • upgrade Graphene to Alpha2 (or Alpha3-SNAPSHOT) + subsequent modifications:
    • StaleReferenceAwareFieldDecorator should not be necessary
    • use @page instead of PageFactory
    • diverge Page Fragment for b:pickList from PickListPage [1]

[1] http://arquillian.org/blog/2012/09/19/introducting-arquillian-graphene-page-fragments/

@buildhive
Copy link

RichFaces » sandbox #283 SUCCESS
This pull request looks good
(what's this?)

@lfryc
Copy link
Contributor

lfryc commented Mar 13, 2013

Hey Jirka, finally I was able to merge your contribution to develop.

I have made some changes:

  • reused continous integration setup configured in richfaces-root-parent (it was recently introduced; avoids duplication of efforts)

5f58550

Note that not all tests pass in Chrome now - would be great if you will have chance to look at them:

  • testAddByDND
  • testRemoteByDND

What we need to do further?

  • move page fragments to bootstrap-ui (similarly as we will do in core framework)

@lfryc lfryc closed this Mar 13, 2013
@lfryc
Copy link
Contributor

lfryc commented Mar 13, 2013

One more thing, the ShrinkWrap Maven Resolver is not able to resolve the build output - I have made this nasty workaround: fe7497f#L1R46

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants