Merge pull request #1 from lfryc/RF-11020

introducing JBoss Community checkstyle rules (RF-11019), reformatted resource files (RF-11020)

pom.xml

@@ -1,36 +1,37 @@
-    <!--
-        JBoss, Home of Professional Open Source Copyright 2010, Red Hat,
-        Inc. and individual contributors by the @authors tag. See the
-        copyright.txt in the distribution for a full listing of
-        individual contributors. This is free software; you can
-        redistribute it and/or modify it under the terms of the GNU
-        Lesser General Public License as published by the Free Software
-        Foundation; either version 2.1 of the License, or (at your
-        option) any later version. This software is distributed in the
-        hope that it will be useful, but WITHOUT ANY WARRANTY; without
-        even the implied warranty of MERCHANTABILITY or FITNESS FOR A
-        PARTICULAR PURPOSE. See the GNU Lesser General Public License
-        for more details. You should have received a copy of the GNU
-        Lesser General Public License along with this software; if not,
-        write to the Free Software Foundation, Inc., 51 Franklin St,
-        Fifth Floor, Boston, MA 02110-1301 USA, or see the FSF site:
-        http://www.fsf.org.
-    -->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<!--
+    JBoss, Home of Professional Open Source Copyright 2010, Red Hat,
+    Inc. and individual contributors by the @authors tag. See the
+    copyright.txt in the distribution for a full listing of
+    individual contributors. This is free software; you can
+    redistribute it and/or modify it under the terms of the GNU
+    Lesser General Public License as published by the Free Software
+    Foundation; either version 2.1 of the License, or (at your
+    option) any later version. This software is distributed in the
+    hope that it will be useful, but WITHOUT ANY WARRANTY; without
+    even the implied warranty of MERCHANTABILITY or FITNESS FOR A
+    PARTICULAR PURPOSE. See the GNU Lesser General Public License
+    for more details. You should have received a copy of the GNU
+    Lesser General Public License along with this software; if not,
+    write to the Free Software Foundation, Inc., 51 Franklin St,
+    Fifth Floor, Boston, MA 02110-1301 USA, or see the FSF site:
+    http://www.fsf.org.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
     <parent>
         <groupId>org.jboss</groupId>
         <artifactId>jboss-parent</artifactId>
         <version>5</version>
     </parent>
-    
+
     <groupId>org.richfaces</groupId>
     <artifactId>richfaces-build-checkstyle</artifactId>
     <version>3-SNAPSHOT</version>
     <name>Richfaces Checkstyle</name>
-    
+
     <description>Contains the checkstyle settings for the RichFaces project</description>
-    
+
     <build>
         <plugins>
             <!-- For the release this parent pom -->

src/main/resources/richfaces-checkstyle/richfaces-checkstyle.xml

@@ -3,6 +3,57 @@
 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
         "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
 <module name="Checker">
+
+    <!-- JBoss Community -->
+
+    <module name="FileTabCharacter">
+        <property name="eachLine" value="true"/>
+    </module>
+
+    <module name="RegexpSingleline">
+        <!-- \s matches whitespace character, $ matches end of line. -->
+        <property name="format" value="\s+$"/>
+        <property name="message" value="Line has trailing spaces."/>
+    </module>
+
+    <module name="TreeWalker">
+
+        <property name="cacheFile" value="${checkstyle.cache.file}"/>
+
+        <!-- Checks for imports                              -->
+        <module name="AvoidStarImport"/>
+        <module name="RedundantImport"/>
+        <!-- Disabled until checkstyle can recognize imports which are used only by javadoc -->
+        <!--<module name="UnusedImports"/>-->
+
+        <!-- Modifier Checks                                    -->
+        <module name="ModifierOrder"/>
+        <module name="RedundantModifier"/>
+
+        <!-- Checks for blocks. You know, those {}'s         -->
+        <module name="LeftCurly"/>
+
+        <!-- Checks for common coding problems               -->
+        <!-- Disabled until http://sourceforge.net/tracker/?func=detail&aid=2843447&group_id=29721&atid=397078 is fixed-->
+        <!--<module name="DoubleCheckedLocking"/>-->
+        <module name="EmptyStatement"/>
+        <module name="EqualsHashCode"/>
+        <module name="IllegalInstantiation"/>
+        <module name="RedundantThrows">
+            <property name="allowUnchecked" value="true"/>
+        </module>
+
+        <!-- Miscellaneous other checks.                   -->
+        <module name="UpperEll"/>
+        <module name="PackageAnnotation"/>
+        <module name="CovariantEquals"/>
+        <module name="ArrayTypeStyle"/>
+
+    </module>
+
+
+    <!--  RichFaces Specific -->
+
     <property name="severity" value="error"/>
     <module name="Translation"/>
     <!--<module name="FileLength">-->
@@ -64,9 +115,6 @@
     <module name="TreeWalker">
         <!-- Checks for imports                                       -->
         <!-- See http://checkstyle.sourceforge.net/config_import.html -->
-        <module name="AvoidStarImport">
-            <property name="severity" value="warning"/>
-        </module>
         <module name="IllegalImport">
             <property name="severity" value="error"/>
         </module>