Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 4.1 path #23

Merged
merged 1 commit into from
May 25, 2021
Merged

add 4.1 path #23

merged 1 commit into from
May 25, 2021

Conversation

nbenn
Copy link
Contributor

@nbenn nbenn commented May 25, 2021

I'm happy to add to this PR, to make this automatic, e.g. by pulling in versions using r-hub/rversions. What do you think?

@richfitz
Copy link
Owner

Thanks @nbenn! The place to make it automatic would be in drat.builder (https://github.com/richfitz/drat.builder) which I'll do now. We could hit r-hub for this, though it changes much less frequently than we update the repo. Hopefully by the time that 4.2 has come out we'll be fully transitioned to r-universe (https://mrc-ide.r-universe.dev/ui#packages)

@richfitz richfitz merged commit 713d087 into richfitz:master May 25, 2021
@richfitz
Copy link
Owner

Sorry I totally misread the repo that this was in 🤦

Thanks again!

@nbenn
Copy link
Contributor Author

nbenn commented May 25, 2021

While you're at it, somewhere around

p <- file.path(path, "bin", platform, "contrib", version)

utils::contrib.url() might be of use for path construction? Also, for macOS, not all combinations of "type" and version might be required (at least this is the case on CRAN). From what I saw, it goes something like

  • mac.binary.mavericks: 3.2 through 3.3
  • mac.binary.el-capitan: 3.4 through 3.6
  • mac.binary: 4.0 and onwards

Just fyi, it also works fine the way it is currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants