Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweaks for new autobrew #44

Merged
merged 1 commit into from Jan 7, 2021
Merged

Small tweaks for new autobrew #44

merged 1 commit into from Jan 7, 2021

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Jan 6, 2021

I have made some changes to the autobrew scripts to make it faster and support ARM64. It is now recommended to let the script set the appropriate PKG_CFLAGS and PKG_LIBS for you.

@codecov-io
Copy link

Codecov Report

Merging #44 (9a14303) into master (83b0614) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1476      1476           
=========================================
  Hits          1476      1476           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83b0614...9a14303. Read the comment docs.

Copy link
Owner

@richfitz richfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - do I need to update this on CRAN too or is it ok for now?

@richfitz richfitz merged commit 7950892 into richfitz:master Jan 7, 2021
@jeroen
Copy link
Contributor Author

jeroen commented Jan 7, 2021

No, it's ok for now, I didn't make any breaking changes.

@jeroen jeroen deleted the patch-1 branch January 7, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants