[WIP] Add mipmap generation capability #22
+395
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mipmap generation capabilities.
I'm not super used to c++ so I feel like I might be doing a few things that are needlessly copying memory, I can fix these if someone tells me what needs fixing.
There is also probably a few things that could be cleaned up regarding my code and possibly some member variables that are no longer necessary, which could also be work removing.
I have also not explored how this affects the RDO parts of the code, I just let it run over all blocks for all mipmap levels and hoped for the best.
I added a normal map mipmap filter mode, but I'm not 100% that it's "correct" either, works fine for my purposes but might not be flawless.