Fix detection of SSE2 with Visual Studio #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code assumed that SSE2 is available when building with Visual Studio, but that's not accurate on ARM with UWP. SSE2 could also be enabled on x86 if `_M_IX86_FP == 2`, but it requires checking first that it's not actually set to 2 for AVX, AVX2 or AVX512 (see https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019), so I left it out for this quick fix.
akien-mga
force-pushed
the
fix-msvc-sse2-detection
branch
from
54ee28b
to
ae74fa2
Compare
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
May 7, 2020
The previous code would always use SSE2 intrinsics, which is not valid on UWP ARM platforms (and likely not on some x86 platforms either). The patch has been submitted upstream too: richgel999/jpeg-compressor#13
akien-mga
added a commit
to godotengine/godot
that referenced
this pull request
May 7, 2020
The previous code would always use SSE2 intrinsics, which is not valid on UWP ARM platforms (and likely not on some x86 platforms either). The patch has been submitted upstream too: richgel999/jpeg-compressor#13 (cherry picked from commit 3806efb)
|
Got it - Thanks a lot! |
edg1000
pushed a commit
to edg1000/https-github.com-godotengine-godot
that referenced
this pull request
Apr 23, 2024
The previous code would always use SSE2 intrinsics, which is not valid on UWP ARM platforms (and likely not on some x86 platforms either). The patch has been submitted upstream too: richgel999/jpeg-compressor#13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code assumed that SSE2 is available when building with
Visual Studio, but that's not accurate on ARM with UWP.
SSE2 could also be enabled on x86 if
_M_IX86_FP == 2, but it requireschecking first that it's not actually set to 2 for AVX, AVX2 or AVX512
(see https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019),
so I left it out for this quick fix.