mute the video #45
Closed
mute the video #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least on iOS this works and has the benefit the user's music doesn't stop playing yet it still doesn't sleep
|
I'm going to test this now on both Android and iOS devices! |
|
According to #47 this does not actually mute the video on Android devices. We might want to keep the idea provided in this PR + include a separate video src for Android devices that does not include an audio track (only iOS Safari requires an audio track in the video to enable wake lock). |
|
I have a similar solution but I unmute the video inside the enable method before playing it so that it works on both iOS and Android. |
|
Merged as part of #58. Thank you for this! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on iOS this works and has the benefit the user's
music doesn't stop playing yet it still doesn't sleep.
I don't have Android to test on