Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variants not updating content #16

Closed
kows opened this issue Apr 4, 2023 · 2 comments
Closed

Variants not updating content #16

kows opened this issue Apr 4, 2023 · 2 comments
Labels
bug Something isn't working
Milestone
1.2.0

Comments

@kows
Copy link

kows commented Apr 4, 2023 •
edited
Loading

When outputting culture specific content (currency format, dictionary values) inside the blocks Razor views,
this does not seem to apply the variant's culture.
@kows kows changed the title Variants not alternating content Variants not updating content Apr 4, 2023
@rickbutterfield rickbutterfield added this to the 1.2.0 milestone Apr 4, 2023
@rickbutterfield rickbutterfield added the bug Something isn't working label Apr 4, 2023
@rickbutterfield
Copy link
Owner

I've managed to replicate this issue. The culture isn't being shared to the thread all the way down the call stack, so I'm having to set it again just before the preview is rendered. Will be released in 1.2.0.

rickbutterfield added a commit that referenced this issue Apr 12, 2023
@rickbutterfield
Fixes #14 #16
300a4fb
@rickbutterfield
Copy link
Owner

Fixed in v1.2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@rickbutterfield @kows