Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

couple of enhancements #24

Merged
merged 8 commits into from
May 26, 2024
Merged

couple of enhancements #24

merged 8 commits into from
May 26, 2024

Conversation

adq
Copy link
Contributor

@adq adq commented Apr 27, 2024

Hi, I've got a remarkable 2 with the type folio option.

  • There's a checkbox paragraph option for textual lists (this may not need a type folio tho).
  • The unknown int in PageInfo is a counter of how many times the document has been edited with the type folio - not how many characters, more like the number of "sessions".

@adq
Copy link
Contributor Author

adq commented Apr 27, 2024

Please see #25 -- using the JSON debug files I've implemented block types 8 + 13 as well now.

adq and others added 4 commits April 28, 2024 01:09
- Fix extra data test (since the previous extra data example is now
handled properly!)

- Add test rm data file including new block

- Make the `move_id` attribute of the Line scene item be optional.

- Adjust the version info of the new 0x0D SceneInfo block and update
version info of the 0x02 TreeNodeBlock to make roundtripping work.
@ricklupton ricklupton merged commit 7331e6d into ricklupton:main May 26, 2024
6 checks passed
@ricklupton
Copy link
Owner

Thanks for contributing @adq! I added your test file shared in issue #25 to the tests (hope that's ok) and made a few tweaks so they pass. I've also updated the changelog and listed you as a contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants