Add sequelize & migration #1
Conversation
| @@ -0,0 +1,8 @@ | |||
| module.exports = { | |||
| development: { | |||
There was a problem hiding this comment.
I think docker is a good env name in current setup. It tells this setting is assuming docker setup and the setting are passing via envvar.
There was a problem hiding this comment.
sequelize-cli use development as config key, need to change NODE_ENV or add env argument if want to change this.
docker-compose.yml
Outdated
| - ./pages:/usr/src/app/pages | ||
| - ./plugins:/usr/src/app/plugins | ||
| - ./server:/usr/src/app/server | ||
| - ./static:/usr/src/app/static |
There was a problem hiding this comment.
Why we want this?
I assume you want to keep the node_modules inside docker and outside docker is separated.
This setup have potential when developer adding a new folder and forgot to add here. I prefer the original setup.
There was a problem hiding this comment.
Map node_modules into docker is slow
| { name: 'Alexandre' }, | ||
| { name: 'Pooya' }, | ||
| { name: 'Sébastien' }, | ||
| ])), |
There was a problem hiding this comment.
Seed data and migration is better separated.
| @@ -1,16 +1,25 @@ | |||
| version: '2' | |||
| version: '3' | |||
There was a problem hiding this comment.
Good, Sorry I don't use the latest version.
Connects likecoin#5