Add CI & tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickmak
reviewed
Jun 6, 2018
README.md
Outdated
| ``` bash | ||
| ./run_test.sh | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Please use Makefile as entry point instead of shell script.
__mocks__/ipfs-api.js
Outdated
| mockFiles = files; | ||
| }, | ||
| files: { | ||
| cat: jest.fn().mockImplementation(path => Promise.resolve(mockFiles[path])), |
There was a problem hiding this comment.
Our prettierrc is "arrowParens": "always",
__tests__/integration/api/api.js
Outdated
| @@ -0,0 +1,10 @@ | |||
| const axios = require('axios'); | |||
| // import axios from 'axios'; | |||
__tests__/integration/api/api.js
Outdated
| const port = process.env.PORT || 3000; | ||
|
|
||
| module.exports = { | ||
| get: url => axios.get(`http://${host}:${port}/api/${url}`), |
server/models/index.js
Outdated
|
|
||
| fs.readdirSync(__dirname).forEach((file) => { | ||
| if (file === 'index.js' || file === 'base.js') { | ||
| return; | ||
| } | ||
|
|
||
| const model = sequelize.import(path.join('../', __dirname, file)); | ||
| const model = sequelize.import(path.join(isTest ? '' : '../', __dirname, file)); |
There was a problem hiding this comment.
I prefer to make a variable sequelizePath right after L14. It help to group up the testing related logic in one place.
|
@rickmak updated, the travis fix is due to their image using port 5432 therefore cannot expose the same port |
|
I think this PR is mergeable. The command less stateful will be better, to achieve this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects likecoin#23