Skip to content

Commit

Permalink
fix(run): resolve issue with data_dir input argument (#409)
Browse files Browse the repository at this point in the history
This commit addresses a bug where the `--data_dir` input argument was
not correctly utilized. The issue prevented the application from
accessing the specified data directory. This fix ensures that the
`--data_dir` argument is appropriately recognised and applied.
  • Loading branch information
rickstaa committed Feb 13, 2024
1 parent 9f36055 commit 8d93610
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion stable_learning_control/algos/pytorch/lac/lac.py
Original file line number Diff line number Diff line change
Expand Up @@ -1870,7 +1870,7 @@ def lac(
# Setup output dir for logger and return output kwargs.
logger_kwargs = setup_logger_kwargs(
args.exp_name,
args.seed,
seed=args.seed,
save_checkpoints=args.save_checkpoints,
use_tensorboard=args.use_tensorboard,
tb_log_freq=args.tb_log_freq,
Expand Down
2 changes: 1 addition & 1 deletion stable_learning_control/algos/pytorch/latc/latc.py
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ def latc(env_fn, actor_critic=None, *args, **kwargs):
# Setup output dir for logger and return output kwargs.
logger_kwargs = setup_logger_kwargs(
args.exp_name,
args.seed,
seed=args.seed,
save_checkpoints=args.save_checkpoints,
use_tensorboard=args.use_tensorboard,
tb_log_freq=args.tb_log_freq,
Expand Down
4 changes: 2 additions & 2 deletions stable_learning_control/algos/pytorch/sac/sac.py
Original file line number Diff line number Diff line change
Expand Up @@ -1657,15 +1657,15 @@ def sac(
# Setup output dir for logger and return output kwargs.
logger_kwargs = setup_logger_kwargs(
args.exp_name,
args.seed,
seed=args.seed,
save_checkpoints=args.save_checkpoints,
use_tensorboard=args.use_tensorboard,
tb_log_freq=args.tb_log_freq,
use_wandb=args.use_wandb,
wandb_job_type=args.wandb_job_type,
wandb_project=args.wandb_project,
wandb_group=args.wandb_group,
wandb_run_name=args.wandb_run_name,
tb_log_freq=args.tb_log_freq,
quiet=args.quiet,
verbose_fmt=args.verbose_fmt,
verbose_vars=args.verbose_vars,
Expand Down
2 changes: 1 addition & 1 deletion stable_learning_control/algos/tf2/lac/lac.py
Original file line number Diff line number Diff line change
Expand Up @@ -1769,7 +1769,7 @@ def lac(
# Setup output dir for logger and return output kwargs.
logger_kwargs = setup_logger_kwargs(
args.exp_name,
args.seed,
seed=args.seed,
save_checkpoints=args.save_checkpoints,
use_tensorboard=args.use_tensorboard,
tb_log_freq=args.tb_log_freq,
Expand Down
2 changes: 1 addition & 1 deletion stable_learning_control/algos/tf2/latc/latc.py
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ def latc(env_fn, actor_critic=None, *args, **kwargs):
# Setup output dir for logger and return output kwargs.
logger_kwargs = setup_logger_kwargs(
args.exp_name,
args.seed,
seed=args.seed,
save_checkpoints=args.save_checkpoints,
use_tensorboard=args.use_tensorboard,
tb_log_freq=args.tb_log_freq,
Expand Down
2 changes: 1 addition & 1 deletion stable_learning_control/algos/tf2/sac/sac.py
Original file line number Diff line number Diff line change
Expand Up @@ -1573,7 +1573,7 @@ def sac(
# Setup output dir for logger and return output kwargs.
logger_kwargs = setup_logger_kwargs(
args.exp_name,
args.seed,
seed=args.seed,
save_checkpoints=args.save_checkpoints,
use_tensorboard=args.use_tensorboard,
tb_log_freq=args.tb_log_freq,
Expand Down
3 changes: 1 addition & 2 deletions stable_learning_control/utils/run_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,8 @@ def call_experiment(
# Set up logger output directory.
if "logger_kwargs" not in kwargs:
kwargs["logger_kwargs"] = setup_logger_kwargs(
exp_name, seed, data_dir, datestamp
exp_name, seed=seed, data_dir=data_dir, datestamp=datestamp
)

else:
print("Note: Call experiment is not handling logger_kwargs.\n")
kwargs["logger_kwargs"] = setup_logger_kwargs(
Expand Down

0 comments on commit 8d93610

Please sign in to comment.