Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagePool.process(fn) doesn't propagate errors in fn #2

Open
zenflow opened this issue Sep 6, 2019 · 0 comments
Open

pagePool.process(fn) doesn't propagate errors in fn #2

zenflow opened this issue Sep 6, 2019 · 0 comments

Comments

@zenflow
Copy link

zenflow commented Sep 6, 2019

If an error is thrown in the function you pass to .process(), it get's swallowed and disappears.

I was pretty confused at what was going on before I realized this!

If pagePool.process encounter's an error calling fn, it should propagate the error (i.e. re-throw it) so it can be handled higher up the call stack.

Thanks for the neat package btw :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant