Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the copying of changelog lines less brittle #125

Merged
merged 1 commit into from May 30, 2020

Conversation

pabs3
Copy link
Contributor

@pabs3 pabs3 commented May 26, 2020

Stop copying changelog lines when a changelog header containing the exact
version is seen. Until now, random other versions that happened to contain
the installed version did this. Also, any non-header lines that happened to
mention the installed version also did this.

This isn't the most correct fix though, the right way to do this would be
to reimplement the code using proper changelog parsing from the Python
debian module.

@rickysarraf
Copy link
Owner

Can you please rebase this PR ?

Stop copying changelog lines when a changelog header containing the exact
version is seen. Until now, random other versions that happened to contain
the installed version did this. Also, any non-header lines that happened to
mention the installed version also did this.

This isn't the most correct fix though, the right way to do this would be
to reimplement the code using proper changelog parsing from the Python
debian module.
@pabs3 pabs3 force-pushed the fix-changelog-generation branch from 922c56d to 2528795 Compare May 30, 2020 07:57
@rickysarraf
Copy link
Owner

Stop copying changelog lines when a changelog header containing the exact
version is seen. Until now, random other versions that happened to contain
the installed version did this. Also, any non-header lines that happened to
mention the installed version also did this.

This isn't the most correct fix though, the right way to do this would be
to reimplement the code using proper changelog parsing from the Python
debian module.

Which python debian module are you referring to hear ?

@rickysarraf
Copy link
Owner

Which python debian module are you referring to hear ?

But given that changelog functionality depends on the availability of python-apt, this is Linux only. No cross-platform support required.

@pabs3
Copy link
Contributor Author

pabs3 commented May 30, 2020 via email

@rickysarraf
Copy link
Owner

I was referring to the module you get when you 'import debian', which is provided by the python3-debian package within Debian.

-- bye, pabs https://wiki.debian.org/PaulWise

Yes. That looks like a better option.

@rickysarraf rickysarraf merged commit b806385 into rickysarraf:master May 30, 2020
@pabs3 pabs3 deleted the fix-changelog-generation branch May 30, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants