Fix Config Generation when Pod has no IP Address #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Pod was already created, but doesn't had an IP address assigned yet, the configuration only contained the port number instead of the full address of the Pod. We are no checking that the Pod has an IP address assigned and if this is not the case we skip the Pod. We also improved the update logic of the generated secret with the Parca configuration. Therefor we are checking the the list of Pod IPs is not empty and not equal to the list of Pod IPs saved in the status field of the ParcaScrapeConfig CR. Only when the Pod IPs are not equal to the saved list of Pod IPs we will update the configuration. For all other cases we skip the update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Pod was already created, but doesn't had an IP address assigned yet, the configuration only contained the port number instead of the full address of the Pod. We are no checking that the Pod has an IP address assigned and if this is not the case we skip the Pod.
We also improved the update logic of the generated secret with the Parca configuration. Therefor we are checking the the list of Pod IPs is not empty and not equal to the list of Pod IPs saved in the status field of the ParcaScrapeConfig CR. Only when the Pod IPs are not equal to the saved list of Pod IPs we will update the configuration. For all other cases we skip the update.