Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure auth backend #114

Merged
merged 4 commits into from
Jun 27, 2021
Merged

Add azure auth backend #114

merged 4 commits into from
Jun 27, 2021

Conversation

Pale-whale
Copy link
Contributor

Hello !

First of all, thanks for this project ! We were having problems with argocd syncing mutated secrets with our ancient controller and this will be an amazing piece of code to run in our clusters :)
But since we are on azure and use managed aks we also use the Managed System Identities to authenticate against the Vault API, so the aim of this PR is to be able to get this identity on aks and send the token to the vault

I've basically copy/pasted the kubernetes auth method and changed the jwt retrival with a curl to azure services.
I'm quite not sure about the name of the environment variables, I tried to keep a cohesion with what was existing

I've updated the chart and the readme accordingly but if there's anything wrong I can correct that :)

Also this support only managed system identities present on azure VM and VMScaleSet Microsoft doc

Thanks :)

@ricoberger
Copy link
Owner

Hi @Pale-whale thanks for your contribution.

Your contribution looks good to me, but unfortunately I haven't a Vault instance with an Azure backend. I would create a new release with your addition. If you see any problems it a follow up PR would be highly appreciated.

@ricoberger ricoberger merged commit 7f01acf into ricoberger:master Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants