Automatic determination of KV version #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the logic from the Vault cli to determine the used version of the secrets engine. This also fixes the problem, when a KVv2 secrets engine was mounted under a nested path. The secretEngine field in the CR is no longer needed, but stays. So we do not introduce a breaking change and we can reuse it later if we implement other secret engines. TODO: - Improve description for the secretEngine field - Improve comments
Improve the description for the CR to make clear, which fields are required and which fields can omitted. Replace KV2 with the more common KVv2 format in the code comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the logic from the Vault cli to determine the used version of the secrets engine. This also fixes #11.
We keep the
secretEnginefield in the CR, to not introduce a breaking change. The field can also reused later, if we implement other secret engines.ToDo: