Added finalizers for OpenShift in RBAC

[bartmeuris]

Fixes an OpenShift RBAC compatibility issue in helm chart. Found the solution here: spotahome/redis-operator#98

If you don't specifically mention the vaultsecrets/finalizers resource next to the vaultsecrets in the ClusterRole, you get an error like this in the reconciliation loop:

2020-12-28T15:06:04.328Z	INFO	controllers.VaultSecret	Creating a new Secret	{"vaultsecret": "testnamespace/test-vault-secret", "Secret.Namespace": "testnamespace", "Secret.Name": "test-vault-secret"}
2020-12-28T15:06:04.334Z	ERROR	controller	Reconciler error	{"reconcilerGroup": "ricoberger.de", "reconcilerKind": "VaultSecret", "controller": "vaultsecret", "name": "test-vault-secret", "namespace": "testnamespace", "error": "secrets \"test-vault-secret\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>"}
github.com/go-logr/zapr.(*zapLogger).Error

I currently wrapped the additional resource in a condition which checks for an OpenShift specific API to be present on the target cluster. Not sure if this is the way to go, and if this condition is even necessary. I have only tested this with Helm 3 on OpenShift 4, and briefly on a local kind instance.

[ricoberger]

Hi @bartmeuris, thanks for finding the bug and fixing it 🙂.

If you are ok with it, I would merge #67 instead of your PR, which also fixes the markers for the generation of the RBAC rules. They were not added after the migration to the new Operator SDK version and I would like to use make manifest in the future without any hassle.

[bartmeuris]

Ah that would be a better solution indeed, feel free to close/ignore this PR then :)

[ricoberger]

The fix is included in version 1.10.2