Add basic action command #197
Conversation
| case Qt::DisplayRole: return message.text; | ||
| case Qt::DisplayRole: | ||
| if (message.text.startsWith(QStringLiteral("/me "))) { | ||
| return QStringLiteral("* %1 %2").arg(m_contact->nickname(), message.text.mid(4, -1)); |
There was a problem hiding this comment.
Some thoughts:
If the message is just "/msg " then the resulting message is "* nick " which is a little odd. I believe it would be better (and more friendly) if it was "nick did nothing"
Also these look like regular messages, it would be nice to do something like src/ui/LinkedText.cpp to alter the look of these messages so they stand out more (so then you could return the "/me..." string here and morph all strings that being like that on the UI end instead of here - this allows some more flexibility later on if we want to add more actions.)
There was a problem hiding this comment.
I think that customising text here is OK (better, even, in a lot of ways. The C++ string operations are a lot more straightforward from an operational & performance standpoint than having to do them in JS). Changing later, if it's required, is pretty straightforward.
For customizing the appearance, you could add a new role (IsActionMessageRole, maybe) using the startsWith check for the value, and on the UI side, change the text color or whatever fanciness you find appropriate.
|
Oh, I see you already arrived at the role conclusion here. I personally think a role would be handy, but it's only actually useful if you also find a neat way to customize the styling. Maybe @special has an idea on how it could look. |
|
Here's what it looks like in iMessage:
That approach could work nicely, although it adds another complex case to the message delegate. I'm okay with this as-is. It would be neat if somebody finds a fancier way to present it eventually. |
Rudimentary implementation of #13
Would you prefer to add an isActionRole to the model so the message can be styled a little differently?