Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 6 Compatibility Suite / Migrate to tape #354

Closed
ricokahler opened this issue Feb 23, 2021 · 1 comment
Closed

Node 6 Compatibility Suite / Migrate to tape #354

ricokahler opened this issue Feb 23, 2021 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@ricokahler
Copy link
Owner

When version 1 of this lib was released, it (unknowingly) supported Node 6. See #351 for context.

Long story short, there should be some CI in place to ensure that this lib will continue supporting Node 6 in the future.

I need some help getting that done via Github actions. Any takers?
@ricokahler ricokahler added the help wanted Extra attention is needed label Feb 23, 2021
@ricokahler ricokahler mentioned this issue Feb 23, 2021
Closed
@ricokahler
Copy link
Owner Author

Just got off the phone with @ljharb. He suggested migrating all of the tests to tape for node 6 compat. I think this is a good direction and will ensure better compatibility.

@ljharb feel free to write that PR, I'll take a look right away!

@ricokahler ricokahler changed the title Node 6 Compatibility Suite Node 6 Compatibility Suite / Migrate to tape Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricokahler