Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

Mux video input #145

Closed
RobEasthope opened this issue Jul 8, 2021 · 3 comments
Closed

Mux video input #145

RobEasthope opened this issue Jul 8, 2021 · 3 comments

Comments

@RobEasthope
Copy link

I'm using Mux's Sanity input plugin to host video but sanity-codegen is throwing an issue due to the fullstop in the name:

Error: Name "mux.video" is not valid. Ensure camel case, alphanumeric, and underscore characters only

Is there a way to ignore or alias the plugin when generating types?
@RobEasthope RobEasthope changed the title Mux video input won't compile Mux video input Jul 8, 2021
@RobEasthope RobEasthope mentioned this issue Jul 8, 2021
Closed
@ricokahler
Copy link
Owner

I think you've caught a valid use case of . in an identifier. I think the best path forward is to allow full stops if it's used as a type (vs a name). I can have this out soon. Thanks for catching it!

@ricokahler
Copy link
Owner

Fixed in v0.9.4. Thanks a bunch!

@RobEasthope
Copy link
Author

Perfect, thanks @ricokahler and thanks for your work on the plugin, it's been a great help

refactorized added a commit to refactorized/sanity-codegen that referenced this issue Dec 9, 2021
@refactorized
Basic generic embed impl, pb and pt (ricokahler#145)
c3e69a2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobEasthope @ricokahler