public List<string> operators { get; set; } is causing validation errors

[dyetube]

I'm generating a json schema from a class and everything works except: public Dictionary<string, object> values { get; set; }.

For some reason it converts it to:

"values": { "type": [ "null", "object" ], "additionalProperties": { "type": "object" } },.

What the json should look like is this:

"values": { "employee Only": "Employee Only", "employee and Spouse": "Employee and Spouse", "employee and Children": "Employee and Children", "employee and Family": "Employee and Family" }

This is causing an error to be thrown when it shouldn't.

If you want me to post the fully convert Json Schema, I can but it is quite long. Hopefully this makes sense. I'm thinking the "additionalProperties" is what is causing the error. Am I doing something wrong maybe?

[RicoSuter]

Looks correct to me, can you post exception details?

[dyetube]

It says "ArrayItemNotValid"

Does this screenshot help or do you need more info?

[RicoSuter]

You have a validation error in the filters property not in the values property... Can you post its data and schema as well?

[RicoSuter]

Clarification: JSON Schema does not know dictionaries. The schema describes an object which can have any properties (i.e. the dictionary keys) of type object (i.e. the dictionary values)... Because the property is nullable, its JSON Schema type can be null or object (as described).

[dyetube]

Post the wrong screenshot. I know I do have an error there, I've got that fixed. maybe this screenshot will help better?

[RicoSuter]

Ok, I see the problem. Probably the .NET string is not recognized as JSON Schema object...

[dyetube]

The reason it can be null or object is that I didn't make it required. If it is Null, I get no errors, I only get errors when I populate it with key:value pairs as an object.

[RicoSuter]

I have to implement a Unit Test... I'll report back...

[dyetube]

Ok. Thanks!

[RicoSuter]

According to http://jsonschemalint.com/draft4/ the JSON Schema validation is correct for the given data:

So we have to change the JSON Schema generator...

[RicoSuter]

I've added the following unit test:

    public class DictTest
    {
        public Dictionary<string, object> values { get; set; }
    }

    [TestMethod]
    public void When_dictionary_value_is_null_then_string_values_are_allowed()
    {
        //// Arrange
        var schema = JsonSchema4.FromType<DictTest>();
        var schemaData = schema.ToJson();

        var data = @"{
            ""values"": { 
                ""key"": ""value"", 
            }
        }";

        //// Act
        var errors = schema.Validate(data);

        //// Assert
        Assert.AreEqual(0, errors.Count);
    }

Is this correct?

[RicoSuter]

Commit: 6406618

[RicoSuter]

v2.11 now available via NuGet, please try with this version and report if it works...

[dyetube]

Sorry it took a while to get back with you on this. Yes, this fixed the issue and now dictionary works correctly.

[RicoSuter]

Nice. Thx for reporting the issue and using the library...