Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to use merge-me-action from a workflow_run event #616

Closed
sbrunner opened this issue Nov 16, 2020 · 2 comments · Fixed by #648
Closed

Be able to use merge-me-action from a workflow_run event #616

sbrunner opened this issue Nov 16, 2020 · 2 comments · Fixed by #648
Labels
enhancement New feature or request

Comments

@sbrunner
Copy link
Contributor

What do you want to achieve?

It should be possible to lunch the action on a workflow_runaction, with workflow like this:

name: Auto merge Dependabot updates

on:
  workflow_run:
    workflows:
      - Workflow 1
      - Workflow 2
    types:
      - completed

jobs:
  auto-merge:
    name: Auto merge
    runs-on: ubuntu-latest
    steps:
      - name: Auto merge
        uses: ridedott/dependabot-auto-merge-action@master
        with:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

In this case, we get an event like this (from github context) (largely simplified):

{
  "event_name": "workflow_run",
  "event": {
    "action": "completed",
    "workflow_run": {
      "conclusion": "success",
      "pull_requests": [
        {
          "number": <number>,
          "url": "https://api.github.com/repos/<org>/<repo>/pulls/<number>"
        }
      ]
    }
  }
}

What is the current way of working?

Actually, the merge is done by Dependabot v1

How much does it hurt?

I can't migrate to Dependabot v2, and the solution of putting merge-me-action at the ends of my main workflow doesn't work well because in some cases I should wait on more than one workflow.

@sbrunner sbrunner added the enhancement New feature or request label Nov 16, 2020
@rencsaridogan
Copy link

Thank you @sbrunner!

We like this addition, and would gladly accept contribution for this addition!

If not, due to the priorities on our end, we currently do not know where this would land in our planning for us to implement ourselves.

@sbrunner
Copy link
Contributor Author

Thanks @rencsaridogan

Sure, I will work on it :-)

sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 2, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 2, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 2, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 2, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 2, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 2, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 2, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 2, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 2, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 8, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 8, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 8, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 8, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 8, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 8, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 8, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 8, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 9, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 9, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 9, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 11, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 11, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Dec 11, 2020
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Jan 5, 2021
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Mar 18, 2021
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Mar 18, 2021
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Mar 18, 2021
sbrunner added a commit to sbrunner/merge-me-action that referenced this issue Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants