Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use setFailed instead of logError #469

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Conversation

oleg-koval
Copy link
Contributor

@oleg-koval oleg-koval commented Jul 7, 2020

This Pull Request fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added if needed.
  • Does not affect documentation or it has been added or updated.

@oleg-koval oleg-koval requested review from mad-it, viestat and a team July 7, 2020 15:00
@oleg-koval oleg-koval self-assigned this Jul 7, 2020
@coveralls
Copy link

coveralls commented Jul 7, 2020

Pull Request Test Coverage Report for Build 162108786

  • 6 of 9 (66.67%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 94.634%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/eventHandlers/checkSuite/index.ts 2 3 66.67%
src/eventHandlers/pullRequest/index.ts 2 3 66.67%
src/eventHandlers/push/index.ts 2 3 66.67%
Totals Coverage Status
Change from base Build 160043487: 0.08%
Covered Lines: 128
Relevant Lines: 135

💛 - Coveralls

Copy link
Member

@viestat viestat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly this will make the check fail if the request to GitHub API fails.
This makes sense to me as it provides visibility of why the PR was not merged.

@mad-it mad-it requested review from merlinnot and removed request for mad-it July 8, 2020 12:01
@oleg-koval oleg-koval merged commit 7d4c611 into master Jul 9, 2020
@oleg-koval oleg-koval deleted the oleg-koval/set-failed branch July 9, 2020 08:08
@merlinnot
Copy link
Contributor

@oleg-koval Will it make it fail when the branch is out of date? That happens regularly, Dependabot has to rebase all PRs that are not up to date with the base branch.

@merlinnot merlinnot restored the oleg-koval/set-failed branch July 14, 2020 07:48
@merlinnot merlinnot deleted the oleg-koval/set-failed branch July 14, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants