Refactor/new implementation

[kingdcreations]

close #38

[riderodd]

Nice work @kingdcreations , can you update the Readme with a warning about this breaking change and I take care of the iOS part ?

[riderodd]

@kingdcreations : how do you specify an array of available strings for the recognition now? (the old grammar parameter)

[kingdcreations]

@kingdcreations : how do you specify an array of available strings for the recognition now? (the old grammar parameter)

No changes !

Nice work @kingdcreations , can you update the Readme with a warning about this breaking change and I take care of the iOS part ?

I updated it with new functionalities, but I'd still like to add those:

• Timeout handling, I want to add an argument to start() but as there is no function overloading in js, should i set start() args to an options object like:

start({
 grammar: ["left", "right", "[unk]"],
 timeout: 10000
})

• String promises instead of { data: String } actual one

What do you think ?

[riderodd]

I'm loving it! Can you just add a test on the example app with grammar and one without ?

[kingdcreations]

All done ! However react native 0.73 is here, should i update ?

[riderodd]

All done ! However react native 0.73 is here, should i update ?

No let's keep that for later

[riderodd]

Amazing work thanks !
I'm a bit confused about all the events, but that's the way Vosk works so... If you have any suggestion to make it clearer feel free to make a suggestion !
As soon as everything is resolved I'll work on the iOS side.

[riderodd]

Nice thanks !

[riderodd]

@kingdcreations : would you review my last commits ?

[kingdcreations]

No cleaning/ restart needed ? Even after multiple calls/ recognition ? No leak ?

[riderodd]

Grammar is stored into an internal class variable, for sure it won't work unless you call stop() and start() again. How did you do on Android ? I may have implemented a wrong pattern ^^

[kingdcreations]

I clean the recognizer, call the native setGrammar method, and restart, wdy think ?

@ReactMethod
  fun setGrammar(grammar: ReadableArray? = null, promise: Promise) {
    if (recognizer == null || speechService == null) {
      promise.reject(IOException("Recognizer is not started yet"))
    } else {
      try {
        speechService!!.stop()
        speechService!!.shutdown()

        if (grammar != null)
          recognizer!!.setGrammar(makeGrammar(grammar))
        else
          recognizer!!.setGrammar("[]")

        speechService = SpeechService(recognizer, sampleRate)
        if (speechService!!.startListening(this))
          return promise.resolve("Recognizer successfully started")

      } catch (e: IOException) {
        promise.reject(e)
      }
    }
  }

[riderodd]

@kingdcreations : ok I did the same implementation on my side, but it made me think about the timeout argument that id not preserved, isn't it ? I mean, I call start with timeout: 5, then setGrammar(), and my timeout disappear no ?

[kingdcreations]

You are right, what should i do ?

[riderodd]

In a first time, removing setGrammar seem fine no ? Devs can just call stop() and start() again with grammar in parameters, and they keep control of the recognition state on their UI. Isn't it better?

[kingdcreations]

Yup, lets do that