More flexibility in custom Page types and managers #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 3, 2012 14:50
…er and a ContentItemManager in the app_settings so they can be overridden by other applications, changed models.py to use the PageManager and ContentItemManager from the app_settings (using the class loader)
…in a previous commit
…only Page objects, added content_type to Page model so we have information about subtypes in a Page object + a South migration script, store the subtype when saving objects in Page, instantiate objects of the subclass using the content_type when having a Page object, added a handle function to Page so we can add external logic when handling the request, added a hook in the page request handler to execute external logic
…erPageMixim.get_fiber_page function (stores the same page as the PageSingleton), removed handle function from Page model, removed call to handle function of model (extra handlers should be implemented as context processors now with a check if the page is an instance of the right subclass; a context processor per subclass of Page)
…name and required, in admin the content_type has a filtered queryset of the classes that derive from Page and Page itself, when changing the type of a Page to a subclass the corresponding entry in the database (automatic one-to-one relationship) will be created using the ORM, when changing the type back to Page the relationship will be removed via a fake unmanaged model class so the Page will be still there but the one-to-one relationship is removed (and thus the entry in the database)
mvdwaeter
pushed a commit
to mvdwaeter/django-fiber
that referenced
this pull request
Aug 14, 2012
…er and a ContentItemManager in the app_settings so they can be overridden by other applications - changed models.py to use the PageManager and ContentItemManager from the app_settings (using the class loader) - added credits to douwevandermeij - Issue django-fiber#105
|
Hi Douwe, A lot has happened in the mean time. Do you still use Fiber? And do you still want (more) stuff that's in this pull request to be merged? If so, please contact me (you have my e-mail, right?) so we can discuss the right approach for this. I'm closing this issue / pull request for now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: