Scala, Spark, Luigi, Shell 개발 가이드 추가 #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
boridevna
commented
Nov 13, 2019
boridevna
commented
- 기존에 데이터팀 스타일 가이드에 있던 문서를 보강하여 새롭게 가이드를 추가했습니다.
- Scala, Spark, Luigi
- 관련 아사나 태스크: ridi/data-style-guide 의 내용을 ridi/style-guide 로 이동
- 이전에 제보했던 이슈 shell script 스타일 가이드 추가 #116 에 해당하는 Shell 관련 스타일 가이드도 새롭게 문서를 작성했습니다.
- 고민되는 부분
- Spark, Luigi의 가이드 분류를 어느 항목에 두어야 할지 고민하다 Frameworks 밑에 두었는데 적절할지 의견 부탁드립니다 🙏
nephtyws
reviewed
Nov 15, 2019
| ## Chained Method Invocations | ||
| - chained method 호출은 다음의 경우를 모두 허용한다. | ||
| - on a single line | ||
| - line length가 100 이내이고 가독성을 헤치지 않는 경우 허용 |
There was a problem hiding this comment.
문득 궁금해져서 여쭤보는 건데.. line length를 100 byte로 설정하신 배경이 궁금합니다.
There was a problem hiding this comment.
@nephtyws 요기의 가이드에서 따왔습니다!
https://github.com/databricks/scala-style-guide#linelength
iamchanu
approved these changes
Nov 15, 2019
nephtyws
approved these changes
Nov 15, 2019
namenu
reviewed
Nov 19, 2019
- Change tone from 'must use' to 'recommend' for #ideintegrated-development-environment - Fix typo
|
@namenu 님의 리뷰코멘트를 반영했습니다.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.