Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve riemann.kafka resilience to empty messages (#1016) #1017

Merged
merged 3 commits into from Jun 6, 2022
Merged

Improve riemann.kafka resilience to empty messages (#1016) #1017

merged 3 commits into from Jun 6, 2022

Conversation

szrumi
Copy link
Contributor

@szrumi szrumi commented Jun 4, 2022

No description provided.

@jamtur01
Copy link
Member

jamtur01 commented Jun 4, 2022

Could you please add a test for this? (https://github.com/riemann/riemann/blob/main/test/riemann/kafka_test.clj) Thanks!

@szrumi szrumi force-pushed the bug-1016-kafka-consumer-resilience branch from 3ee01cc to 0f81590 Compare June 5, 2022 21:35
@jamtur01
Copy link
Member

jamtur01 commented Jun 6, 2022

Thanks! Awesome stuff.

@jamtur01 jamtur01 merged commit b41a2b2 into riemann:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szrumi @jamtur01