Allow tagged-any & tagged-all to be used in where exprs #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the single tag form of tagged-any & tagged-all to be used in a where predicate expression. Previously where-rewrite would only recognize tagged. The logic for all three forms is the same in this case because it only checks for the existence of a single tag.
Note that tagged-any & tagged-all can be used in where test expressions, but only the single tag form. Testing for a collection of tags is not supported yet.
ghost
pushed a commit
that referenced
this pull request
Jun 4, 2013
Allow tagged-any & tagged-all to be used in where exprs
ghost
merged commit 
|
Great work, thanks Sam. :D |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the single tag form of tagged-any &
tagged-all to be used in a where predicate expression.
Previously where-rewrite would only recognize tagged.
The logic for all three forms is the same in this case
because it only checks for the existence of a single tag.
Also update the docs for where, tagged-any & tagged-all to note that tagged-* can be used in where test expressions, but only to test for single tags.