Replace refs in moving-time-window by an atom #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcorbin
changed the title
mcorbin
force-pushed
the
feat/moving-time-window-atom
branch
from
f2d33cb
to
71f613f
Compare
mcorbin
force-pushed
the
feat/moving-time-window-atom
branch
from
71f613f
to
32fa155
Compare
|
Some numbers, using riemann-bench on my laptop with this configuration: (streams
(default :ttl 300 (index))
(moving-time-window 1)
(moving-time-window 1)
(moving-time-window 1)
(moving-time-window 1)
(moving-time-window 2)
(moving-time-window 2)
(moving-time-window 2)
(moving-time-window 2))
|
mcorbin
changed the title
|
Heck yes! Great work @mcorbin, long overdue. Your benchmarks look fantastic. :) |
|
Neato! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #797, refs are replaced by an atom for performances.
I want to make some bench before merging.