Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first phase of refactor to allow pluggable transports #82

Merged
merged 4 commits into from Dec 11, 2012
Merged

first phase of refactor to allow pluggable transports #82

merged 4 commits into from Dec 11, 2012

Conversation

pyr
Copy link
Contributor

@pyr pyr commented Dec 11, 2012

The intent of this work is to have simpler ways of plugging arbitrary transports, I'd also like to move to netty for all standard transports (http, websockets, tcp, udp, graphite)

This first PR doesn't have the transport protocol realized, this would pretty quickly allow to have calls in the config such as (provided you have the transport on the classpath, more on this later):

(start-server riemann.transport.Collectd {:port 7171})

@pyr
Copy link
Contributor Author

pyr commented Dec 11, 2012

this says the build failed but it's time related, not related to the PR itself

@aphyr
Copy link
Collaborator

aphyr commented Dec 11, 2012

Awesome work pyr. Two things:

  1. Can you clarify the documentation on what (setup server) does? When is it called--what's the lifecycle? Setup before start? Setup after start? Setup after stop? Any invariants we can provide here would be useful.
  2. I know I'm guilty of this too, but whitespace changes in a separate commit please--just makes it easier for me to review a PR for the important bits. :)

aphyr added a commit that referenced this pull request Dec 11, 2012
first phase of refactor to allow pluggable transports
@aphyr aphyr merged commit 3017ab9 into riemann:master Dec 11, 2012
@aphyr
Copy link
Collaborator

aphyr commented Dec 11, 2012

ALLLLSOOOO let me take a good hard look at that test failure for you. :) Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants