Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: syntax warnings #308

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix: syntax warnings #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db3e37f
fix: remove jinja2 templating delimiters from conditional
gardar Jan 22, 2024
bbe9013
fix: specifying a list of dictionaries for vars is deprecated in favo…
gardar Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tasks/main-container.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
- name: (Container) Register GitLab Runner
include_tasks: register-runner-container.yml
vars:
- actual_gitlab_runner_name: "{{ gitlab_runner.name|default(ansible_hostname+'-'+gitlab_runner_index|string) }}"
actual_gitlab_runner_name: "{{ gitlab_runner.name | default(ansible_hostname + '-' + gitlab_runner_index | string) }}"
when: gitlab_runner.token is defined or gitlab_runner_registration_token | string | length > 0
loop: "{{ gitlab_runner_runners }}"
loop_control:
Expand Down
2 changes: 1 addition & 1 deletion tasks/main-unix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
- name: (Unix) Register GitLab Runner
include_tasks: register-runner.yml
vars:
- actual_gitlab_runner_name: "{{ gitlab_runner.name|default(ansible_hostname+'-'+gitlab_runner_index|string) }}"
actual_gitlab_runner_name: "{{ gitlab_runner.name | default(ansible_hostname + '-' + gitlab_runner_index | string) }}"
when: gitlab_runner.token is defined or gitlab_runner_registration_token | string | length > 0
loop: "{{ gitlab_runner_runners }}"
loop_control:
Expand Down
2 changes: 1 addition & 1 deletion tasks/main-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
- name: (Windows) Register GitLab Runner
include_tasks: register-runner-windows.yml
vars:
- actual_gitlab_runner_name: "{{ gitlab_runner.name|default(ansible_hostname+'-'+gitlab_runner_index|string) }}"
actual_gitlab_runner_name: "{{ gitlab_runner.name | default(ansible_hostname + '-' + gitlab_runner_index | string) }}"
when: gitlab_runner.token is defined or gitlab_runner_registration_token | string | length > 0
loop: "{{ gitlab_runner_runners }}"
loop_control:
Expand Down
2 changes: 1 addition & 1 deletion tasks/validate-runner-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
- name: "Check for deprecated settings: {{ actual_gitlab_runner_name }}"
ansible.builtin.assert:
that:
- "'{{ setting.name }}' not in gitlab_runner"
- "setting['name'] not in gitlab_runner"
fail_msg: "DEPRECATED setting for runner {{ actual_gitlab_runner_name }}: {{ setting.name }} - {{ setting.message }}"
quiet: true
loop:
Expand Down