Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log level #313

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Add log level #313

merged 6 commits into from
Feb 6, 2024

Conversation

nvzkupu
Copy link
Contributor

@nvzkupu nvzkupu commented Jan 29, 2024

This should add all of the necessary bits for adding log_level to the config.toml

insertbefore: BOF
state: present
no_log: "{{ gitlab_runner_no_log_secrets | default(omit) }}"
when: gitlab_runner_log_level is defined # Ensure value is set
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Ensure value is set

is not needed. People working with Ansible know what is defined menas

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove the comments from the other lines if you want to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! I've removed the comment on line 66, as well as all other instances of this comment in this file.

- remove unnecessary comments in global-setup.yml
@guenhter guenhter merged commit 149f22e into riemers:master Feb 6, 2024
1 check failed
@guenhter
Copy link
Collaborator

guenhter commented Feb 6, 2024

Thx for your collaboration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants