vars: unify and move gitlab_runner_timeout_stop_seconds to defaults #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's not really a reason to have different values for each os. This unifies the default to be 7200 and allows overriding it (because it's now just a default var). I use the override for hosts with long running ci jobs. Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
|
Thx for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's not really a reason to have different values for each os. This unifies the default to be 7200 and allows overriding it (because it's now just a default var). I use the override for hosts with long running ci jobs.