Skip to content

Commit

Permalink
Fix image used by some kops presubmit jobs
Browse files Browse the repository at this point in the history
The old image has not been updated in almost a year [0] and is still running Go 1.11:

```
docker run --entrypoint=/usr/local/go/bin/go gcr.io/k8s-testimages/gcloud-in-go:v20190125-cc5d6ecff3 version
go version go1.11.5 linux/amd64
```

We have open PRs [1] which are not compatible with go 1.11 which is causing their presubmits to fail.
This switches those jobs to use the same kubekins image as the E2E jobs.
I see other projects using the same kubekins-e2e image for non-e2e jobs as well [2].

The new image has Go 1.13 as we expect:

```
docker run --entrypoint=/usr/local/go/bin/go gcr.io/k8s-testimages/kubekins-e2e:v20191219-72db7a6-experimental version
go version go1.13.4 linux/amd64
```

[0] https://console.cloud.google.com/gcr/images/k8s-testimages/GLOBAL/gcloud-in-go?gcrImageListsize=30
[1] kubernetes/kops#8203
[2] https://github.com/kubernetes/test-infra/blob/c628c3674eb0c9292812d760232afcdbb7c79c99/config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-presubmits.yaml#L23
  • Loading branch information
rifelpet committed Dec 26, 2019
1 parent c628c36 commit 0f6ecfd
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions config/jobs/kubernetes/kops/kops-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ presubmits:
preset-service-account: "true"
spec:
containers:
- image: gcr.io/k8s-testimages/gcloud-in-go:v20190125-cc5d6ecff3
- image: gcr.io/k8s-testimages/kubekins-e2e:v20191219-72db7a6-experimental
args:
- "--repo=k8s.io/$(REPO_NAME)=$(PULL_REFS)"
- "--root=/go/src"
Expand Down Expand Up @@ -269,7 +269,7 @@ presubmits:
preset-service-account: "true"
spec:
containers:
- image: gcr.io/k8s-testimages/gcloud-in-go:v20190125-cc5d6ecff3
- image: gcr.io/k8s-testimages/kubekins-e2e:v20191219-72db7a6-experimental
args:
- "--repo=k8s.io/$(REPO_NAME)=$(PULL_REFS)"
- "--root=/go/src"
Expand All @@ -289,7 +289,7 @@ presubmits:
preset-service-account: "true"
spec:
containers:
- image: gcr.io/k8s-testimages/gcloud-in-go:v20190125-cc5d6ecff3
- image: gcr.io/k8s-testimages/kubekins-e2e:v20191219-72db7a6-experimental
args:
- "--repo=k8s.io/$(REPO_NAME)=$(PULL_REFS)"
- "--root=/go/src"
Expand Down Expand Up @@ -335,7 +335,7 @@ presubmits:
preset-service-account: "true"
spec:
containers:
- image: gcr.io/k8s-testimages/gcloud-in-go:v20190125-cc5d6ecff3
- image: gcr.io/k8s-testimages/kubekins-e2e:v20191219-72db7a6-experimental
args:
- "--repo=k8s.io/$(REPO_NAME)=$(PULL_REFS)"
- "--root=/go/src"
Expand All @@ -355,7 +355,7 @@ presubmits:
preset-service-account: "true"
spec:
containers:
- image: gcr.io/k8s-testimages/gcloud-in-go:v20190125-cc5d6ecff3
- image: gcr.io/k8s-testimages/kubekins-e2e:v20191219-72db7a6-experimental
args:
- "--repo=k8s.io/$(REPO_NAME)=$(PULL_REFS)"
- "--root=/go/src"
Expand All @@ -375,7 +375,7 @@ presubmits:
preset-service-account: "true"
spec:
containers:
- image: gcr.io/k8s-testimages/gcloud-in-go:v20190125-cc5d6ecff3
- image: gcr.io/k8s-testimages/kubekins-e2e:v20191219-72db7a6-experimental
args:
- "--repo=k8s.io/$(REPO_NAME)=$(PULL_REFS)"
- "--root=/go/src"
Expand Down

0 comments on commit 0f6ecfd

Please sign in to comment.