Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix User Reported Bugs #4

Merged
merged 21 commits into from
Jun 28, 2024
Merged

Fix User Reported Bugs #4

merged 21 commits into from
Jun 28, 2024

Conversation

UnschooledGamer
Copy link
Contributor

@UnschooledGamer UnschooledGamer commented Feb 10, 2024 •
edited by flameface
Loading

Please describe the changes this PR makes and why it should be merged:

This Pull Request attends to the problems to Reported By the users that includes:

  1. Track Class causing rate limits due to the thumbnail property getting initialized and makes a call to the specific source API which causes Rate Limits For the requests being sent in a short period of time.
  2. The clearFilters() method of Filters class not clearing the Applied filters.
  3. Updates the Dependencies.

Status and versioning classification:

  • Solution For the Track Class thumbnail method Rate Limits.
  • Fix the clearFilters() method of Filters class.
  • Update The Dependencies

⬆️ Versioning

Doesn't Bump in this PR

🧪 Testing Checklist

  • Test the solution implemented for Track Class Thumbnail method, Make sure it doesn't cause rate limits
  • Test the clearFilters() method

@UnschooledGamer UnschooledGamer added bug Something isn't working dependencies Pull requests that update a dependency file labels Feb 10, 2024
@UnschooledGamer UnschooledGamer self-assigned this Feb 10, 2024
@UnschooledGamer
Copy link
Contributor Author

UnschooledGamer commented Feb 10, 2024 •
edited
Loading

  • set the correct this context for Track thumbnail getter

Reset testing check list.

UnschooledGamer and others added 12 commits February 11, 2024 12:00
@UnschooledGamer
fix(Track): correct the this context
04d3094
@UnschooledGamer
add test file
6944a11
@UnschooledGamer
feat(Track): cache thumbnail if it exist
7e04b16
@UnschooledGamer
feat(Track): avoid fetching thumbnail each call, cache it
f4b08cb
@UnschooledGamer
refactor: 🎨 Enforce NAME/Version Format For Client-Name Header
73e5b6e
@ThePedroo
refactor: collections/maps
b83624e 
This commit refactors the discord.js collections used in Riffy, replacing it with Node.js/V8 Map.
@ThePedroo
Merge branch 'fix/user-bugs-feats' into main
6d76e33
@flameface
Merge pull request #5 from ThePedroo/main
bd95889 
refactor: collections/maps
@UnschooledGamer
fix: 🐛 Fixes the cacheThumbnail property that was not working
1b19ab0 
* Corrects The format issue in author property package.json, Replaced it with contributors field.
* Sets the correct condition for player#destroy
@flameface
Fixed clearFilters() and added API to fetch songs for autoplay
42bd453
@UnschooledGamer
fix(Track): clubs non-track result/response in tracks and throws Erro…
8941450 
…r in v4 Lavalink
@flameface
Updated some test commands
bc5169e
@UnschooledGamer
Copy link
Contributor Author

UnschooledGamer commented Feb 16, 2024 •
edited
Loading

  • Fix Nodes region support not functioning correctly
  • Fix leastUsedNodes most used nodes instead of least Used.

Nicely speaking it's sorting descending instead of ascending due to b - a logic for sorting

UnschooledGamer and others added 8 commits February 25, 2024 16:08
@UnschooledGamer
Update Types
c61a817
@UnschooledGamer
fix: node regions support
1227dfe 
feat: exception object in resolve method and types

fix: leastUsedNodes sorting
@UnschooledGamer
fix(Riffy): missing 'tracks' in resolve track method's response
bdc998a 
This commit adds the 'tracks' that was accidentally removed and updates types
@UnschooledGamer
feat(riffy): add 'node' property in resolve method, for accurate sele…
e234ea7 
…ction of the node
@UnschooledGamer
fix: Riffy resolve 'node' property error, fix: headers not getting sh…
c78cf0b 
…ow in debug, update: 'nodes' types.
@UnschooledGamer
Fix: [Better Handle No-Audio] Set Player#connected to true after Vo…
4f2d67f 
…ice state & Server event is Received

* refactor: Connection & Player Debug Messages
* Fix(Rest): return promises with await
@UnschooledGamer
feat(Node): Version Checks & Bump pkgs(deps)
8b633e5 
* feat(Node) Adds Version checks
* bump deps
* feat `includeHeaders` in rest makeRequest
@UnschooledGamer
Merge branch 'main' into fix/user-bugs-feats
79e5003
@UnschooledGamer UnschooledGamer marked this pull request as ready for review June 28, 2024 14:11
@UnschooledGamer UnschooledGamer merged commit f53fbf0 into main Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@UnschooledGamer UnschooledGamer

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@UnschooledGamer @ThePedroo @flameface