Don't overwrite by default in UniqueObjectIndex.extend.

riga · Jul 12, 2023 · b4d8d75 · b4d8d75
1 parent 32c8029
commit b4d8d75
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/order/unique.py b/order/unique.py
@@ -243,7 +243,7 @@ def add(self, *args, **kwargs):
 
         return obj
 
-    def extend(self, objs, overwrite=True):
+    def extend(self, objs, overwrite=False):
         """
         Adds multiple new objects to the index. All elements of the sequence *objs*, as well as
         *overwrite*, are forwarded to :py:meth:`add` and the added objects are returned in a list.

diff --git a/tests/test_unique.py b/tests/test_unique.py
@@ -143,7 +143,7 @@ def test_extend(self):
         C, idx = self.make_index()
         self.assertEqual(len(idx), 3)
 
-        objs = idx.extend([C("baz", 3), C("test", 4)])
+        objs = idx.extend([C("baz", 3), C("test", 4)], overwrite=True)
         self.assertEqual(len(idx), 4)
 
         with self.assertRaises(DuplicateNameException):