Skip to content

Commit

Permalink
Fixed editor config configuration, Fixed xml comments warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
adamjez committed Jan 22, 2018
1 parent 8af8f53 commit c637644
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .editorconfig
Expand Up @@ -8,7 +8,7 @@ insert_final_newline = true
# (Please don't specify an indent_size here; that has too many unintended consequences.)

# Code files
[*.cs,*.csx,*.vb,*.vbx]
[*.{cs,csx,vb,vbx}]
indent_size = 4

# Xml project files
Expand All @@ -24,7 +24,7 @@ indent_size = 2
indent_size = 2

# Dotnet code style settings:
[*.{cs, vb}]
[*.{cs,vb}]
# Sort using and Import directives with System.* appearing first
dotnet_sort_system_directives_first = true
# Avoid "this." and "Me." if not necessary
Expand Down
Expand Up @@ -7,7 +7,9 @@

namespace DotVVM.Framework.Compilation
{
/// <summary>
/// Assigns <see cref="Internal.DataContextTypeProperty" /> to all controls that have different datacontext that their parent
/// </summary>
public class DataContextPropertyAssigningVisitor: ResolvedControlTreeVisitor
{
public override void VisitControl(ResolvedControl control)
Expand Down
5 changes: 3 additions & 2 deletions src/DotVVM.Framework/Controls/DotvvmBindableObject.cs
Expand Up @@ -292,7 +292,8 @@ public bool HasBinding<TBinding>(DotvvmProperty property)
/// <summary>
/// Gets all ancestors of this control starting with the parent.
/// </summary>
/// <param name="onlyWhenInChildren">only enumerate until the parent has this control in <see cref="DotvvmControl.Children" />. Note that it may have a non-trivial performance penalty</param>
/// <param name="incudingThis">Returns also the caller control</param>
/// <param name="onlyWhenInChildren">Only enumerate until the parent has this control in <see cref="DotvvmControl.Children" />. Note that it may have a non-trivial performance penalty</param>
public IEnumerable<DotvvmBindableObject> GetAllAncestors(bool incudingThis = false, bool onlyWhenInChildren = false)
{
var ancestor = incudingThis ? this : Parent;
Expand Down Expand Up @@ -354,4 +355,4 @@ protected void CopyProperty(DotvvmProperty sourceProperty, DotvvmBindableObject
}
}
}
}
}
1 change: 1 addition & 0 deletions src/DotVVM.sln
Expand Up @@ -8,6 +8,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Samples", "Samples", "{1301
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{2A88CAC6-514C-4962-8904-976F879B3E9D}"
ProjectSection(SolutionItems) = preProject
.editorconfig = .editorconfig
Local.testsettings = Local.testsettings
..\README.md = ..\README.md
EndProjectSection
Expand Down

0 comments on commit c637644

Please sign in to comment.