Added JavaScript translations for Dictionary methods #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acizmarik
commented
May 26, 2021
| public void JsTranslator_DictionaryClear() | ||
| { | ||
| var result = CompileBinding("Dictionary.Clear()", new[] { typeof(TestViewModel5) }, typeof(void)); | ||
| Assert.AreEqual("dotvvm.dictionaryHelper.clear(Dictionary)", result); |
There was a problem hiding this comment.
use method from arrayHelper
There was a problem hiding this comment.
I will fix this once List translations PR is merged. This will be resolved within translations refactoring PR
src/DotVVM.Framework/Compilation/Javascript/JavascriptTranslatableMethodCollection.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further improves #1014 (which should be merged first). Also relevant for #831.
New
Dictionary<K,V>methodsClear()ContainsKey(key)Remove(key)This also adds an improvement when defining JS translations for methods with generic parameters owned by their declaring type.