Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always render everything in RouteLink #1055

Merged
merged 1 commit into from Jul 29, 2021
Merged

Always render everything in RouteLink #1055

merged 1 commit into from Jul 29, 2021

Conversation

exyi
Copy link
Member

@exyi exyi commented Jun 19, 2021

Both the binding and server-side rendered value should be included in both
Server and Client Mode. Links are essential part of web and should be
server-side rendered whenever possible.

resolves #781

@exyi exyi requested a review from Mylan719 June 19, 2021 09:07
@acizmarik acizmarik added this to the Version 4.0 milestone Jun 23, 2021
Copy link
Member

@acizmarik acizmarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There just seem to be 2 relevant UI tests failing. Also we should probably hold with merging these changes or create a v4-main branch.

@tomasherceg tomasherceg changed the base branch from main to v4-main July 14, 2021 15:54
Both the binding and server-side rendered value should be included in both
Server and Client Mode. Links are essential part of web and should be
server-side rendered whenever possible.

resolves  #781
@exyi exyi merged commit 6ca399f into v4-main Jul 29, 2021
@exyi exyi deleted the routelink-always-ssr branch July 29, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RouteLink - Rendering based on RenderSettings.Mode
2 participants