Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default value for Repeater.RenderAsNamedTemplate #1101

Merged
merged 4 commits into from Aug 22, 2021

Conversation

quigamdev
Copy link
Contributor

A repeater should render templates by default as named templates. It causes js issues in controls like business-pack TreeView etc..

@quigamdev quigamdev requested a review from exyi August 11, 2021 12:03
@exyi
Copy link
Member

exyi commented Aug 12, 2021

It causes js issues in controls like business-pack TreeView

That means that the TreeView is buggy, it should work even in the inline-template.

@quigamdev
Copy link
Contributor Author

I thought that hierarchical controls have to use the script template. Still, this seems to me like a better default behaviour. In case the application of ViewModel is slow browser renders invalid HTML for a split second. Unfortunately, this incorrectly rendered HTML is noticeable. Rendering of a repeater as a named template does not solve this issue entirely but it behaves better than the current default rendering.

Copy link
Member

@exyi exyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@quigamdev quigamdev merged commit 58745be into v4-main Aug 22, 2021
@quigamdev quigamdev deleted the feature/render-named-template-default branch August 22, 2021 08:33
@quigamdev quigamdev added this to the Version 4.0 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants