TemplateHost control #1109
Merged
TemplateHost control #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
reviewed
Aug 22, 2021
Rewritten UI test to test usage in composite controls
exyi
approved these changes
Sep 1, 2021
|
|
||
|
|
||
| protected internal override void OnLoad(IDotvvmRequestContext context) | ||
| { | ||
| ContentTemplate?.BuildContent(context, this); | ||
| var placeHolder = new PlaceHolder(); | ||
| Template.BuildContent(context, placeHolder); |
There was a problem hiding this comment.
Nullable types should complain somewhere here, please add a simple nullcheck to avoid NRE when users forgets to set the property.
Suggested change
| Template.BuildContent(context, placeHolder); | |
| Template.NotNull("TemplateHost.Template is required").BuildContent(context, placeHolder); |
Also, I think it would be convenient to add a constructor overload with template as parameter. Maybe we could also add overload to the AppendChildren(ITemplate) helper method that would automatically create this control.
src/DotVVM.Samples.Common/Views/ControlSamples/TemplateHost/CompositeControlWithTemplate.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #535, we found that it will be useful to have a
TemplateHostcontrol.I've put it in a separate PR and added some UI tests - the control can be used to pass templates in markup controls.