Add a MSBuild task for running yarn build
#1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case yarn is not installed, npm is used. Yarn is preferred, because it takes less time to run it, so it's less annoying. The Target only runs when any typescript file is changed, otherwise it's skipped by MSBuild In case there are some JS error, the build should continue normally, so hopefully it won't cause some build issues This should solve the problem that we forget to build the JS and then something does not work. And when someone clones the repo, it just won't compile because the JS files are missing
exyi
force-pushed
the
msbuild-yarn-task
branch
from
2d19d16
to
2af099f
Compare
|
This seems to work alright. Would you mind removing the |
quigamdev
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case yarn is not installed, npm is used.
Yarn is preferred, because it takes less time to run it, so it's
less annoying.
The Target only runs when any typescript file is changed,
otherwise it's skipped by MSBuild
In case there are some JS error, the build should continue normally,
so hopefully it won't cause some build issues
This should solve the problem that we forget to build the JS and
then something does not work. And when someone clones the repo,
it just won't compile because the JS files are missing