-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capabilities registered by interfaces #1129
Conversation
51f92d2
to
bd98fb0
Compare
} | ||
public interface IObjectWithCapability<TCapability>: IDotvvmObjectLike | ||
{ | ||
} | ||
public interface IDotvvmControl: IRenderable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public interface IDotvvmControl: IRenderable | |
public interface IDotvvmControl: IRenderable, IDotvvmObjectLike |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doccoment here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have reviewed this PR on a call with @exyi.
Please merge it after you solve the notes.
bd98fb0
to
d7f99c7
Compare
f1eb20c
to
11fff82
Compare
This PR adds a
IObjectWithCapability<T>
interface which can be used to register capabilities very simply. It will also mark controls implementing specific capability, which could be used for helper functions (to set html attributes, for example). The interface is only a marker.Plus, there are few general improvements which I needed while testing this: